Fix URI encoding of resolved imports#2628
Open
FnControlOption wants to merge 1 commit intozigtools:masterfrom
Open
Fix URI encoding of resolved imports#2628FnControlOption wants to merge 1 commit intozigtools:masterfrom
FnControlOption wants to merge 1 commit intozigtools:masterfrom
Conversation
The initial URI is already percent encoded, so avoid re-encoding it.
For example, the space in `Application Support` is already encoded
as `%20`. If we re-encode `Application%20Support`, the percent sign
is encoded as `%25`. Then, we get `Application%2520Support`, which
is wrong.
This fixes `std` imports on macOS when Zig is installed in
~/Library/Application Support/Code/User/globalStorage/ziglang.vscode-zig
Follow-up to c005812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial URI is already percent encoded, so avoid re-encoding it.
For example, the space in
Application Supportis already encoded as%20. If we re-encodeApplication%20Support, the percent sign is encoded as%25. Then, we getApplication%2520Support, which is wrong.This fixes
stdimports on macOS when Zig is installed inFollow-up to c005812 / #2608